From 2a3aa294c241b90755b1654113ec4438d3308a44 Mon Sep 17 00:00:00 2001 From: Michael Reichenbach Date: Mon, 8 Mar 2021 15:29:46 +0100 Subject: [PATCH] fix: use seperate backup user for database backups --- restic_compose_backup.env | 3 +++ src/restic_compose_backup/containers_db.py | 14 +++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/restic_compose_backup.env b/restic_compose_backup.env index d0ad1ee..946bac4 100644 --- a/restic_compose_backup.env +++ b/restic_compose_backup.env @@ -11,6 +11,9 @@ EXCLUDE_BIND_MOUNTS=false RESTIC_REPOSITORY=/restic_data RESTIC_PASSWORD=password +BACKUP_MYSQL_USER=root +BACKUP_MYSQL_PASSWORD=my-secret-pw + RESTIC_KEEP_DAILY=7 RESTIC_KEEP_WEEKLY=4 RESTIC_KEEP_MONTHLY=12 diff --git a/src/restic_compose_backup/containers_db.py b/src/restic_compose_backup/containers_db.py index d9b88c3..d6c35e4 100644 --- a/src/restic_compose_backup/containers_db.py +++ b/src/restic_compose_backup/containers_db.py @@ -16,8 +16,8 @@ class MariadbContainer(Container): """dict: get credentials for the service""" return { 'host': self.hostname, - 'username': self.get_config_env('MYSQL_USER'), - 'password': self.get_config_env('MYSQL_PASSWORD'), + 'username': self.get_config_env('BACKUP_MYSQL_USER'), + 'password': self.get_config_env('BACKUP_MYSQL_PASSWORD'), 'port': "3306", } @@ -90,8 +90,8 @@ class MysqlContainer(Container): """dict: get credentials for the service""" return { 'host': self.hostname, - 'username': self.get_config_env('MYSQL_USER'), - 'password': self.get_config_env('MYSQL_PASSWORD'), + 'username': self.get_config_env('BACKUP_MYSQL_USER'), + 'password': self.get_config_env('BACKUP_MYSQL_PASSWORD'), 'port': "3306", } @@ -165,10 +165,10 @@ class PostgresContainer(Container): """dict: get credentials for the service""" return { 'host': self.hostname, - 'username': self.get_config_env('POSTGRES_USER'), - 'password': self.get_config_env('POSTGRES_PASSWORD'), + 'username': self.get_config_env('BACKUP_POSTGRES_USER'), + 'password': self.get_config_env('BACKUP_POSTGRES_PASSWORD'), 'port': "5432", - 'database': self.get_config_env('POSTGRES_DB'), + 'database': self.get_config_env('BACKUP_POSTGRES_DB'), } def ping(self) -> bool: